Преглед изворни кода

[rcore] fix crash in InitWindow, due to unchecked result of InitPlatform (#4803)

* [rcore] fix crash in InitWindow, due to unchecked result of InitPlatform

Check the result of InitPlatform(), if it isn't 0, report the Error
and return. This prevent crashes and allows for gracefully aborting
or recovering by checking IsWindowReady().

Partially-fixes: https://github.com/raysan5/raylib/issues/4801

* [rcore] style: store the result of InitPlatform() before checking it

Small style change that doesn't impact how the code behaves here.
Variable 'result' is not used anywhere else in this block,
it's just for compliance with Raylib's coding conventions.

Requested in PR: https://github.com/raysan5/raylib/pull/4803#discussion_r1976502788

* [rcore] use LOG_WARNING when InitPlatform() fails

...as this is preferred over LOG_ERROR.

Requested-by: https://github.com/raysan5/raylib/pull/4803#discussion_r1976651724
pull/4811/head
sleeptightAnsiC пре 1 недеља
committed by GitHub
родитељ
комит
34159399cf
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
1 измењених фајлова са 7 додато и 1 уклоњено
  1. +7
    -1
      src/rcore.c

+ 7
- 1
src/rcore.c Прегледај датотеку

@ -681,7 +681,13 @@ void InitWindow(int width, int height, const char *title)
// Initialize platform
//--------------------------------------------------------------
InitPlatform();
int result = InitPlatform();
if (result != 0)
{
TRACELOG(LOG_WARNING, "SYSTEM: Failed to initialize Platform");
return;
}
//--------------------------------------------------------------
// Initialize rlgl default data (buffers and shaders)

Loading…
Откажи
Сачувај