From daa2921476fbc98ed45305182e9bae225f4e08ab Mon Sep 17 00:00:00 2001 From: MykBamberg Date: Wed, 12 Mar 2025 01:38:39 +0100 Subject: [PATCH] [rcore] Use snprintf to prevent buffer overflow in path construction --- src/rcore.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/rcore.c b/src/rcore.c index 6739e5f05..4d632e997 100644 --- a/src/rcore.c +++ b/src/rcore.c @@ -3688,12 +3688,16 @@ static void ScanDirectoryFiles(const char *basePath, FilePathList *files, const (strcmp(dp->d_name, "..") != 0)) { #if defined(_WIN32) - sprintf(path, "%s\\%s", basePath, dp->d_name); + int realPathLength = snprintf(path, sizeof(path) - 1, "%s\\%s", basePath, dp->d_name); #else - sprintf(path, "%s/%s", basePath, dp->d_name); + int realPathLength = snprintf(path, sizeof(path) - 1, "%s/%s", basePath, dp->d_name); #endif - if (filter != NULL) + if (realPathLength < 0 || realPathLength >= sizeof(path)) + { + TRACELOG(LOG_WARNING, "FILEIO: Path longer than %d characters (%s...)", MAX_FILEPATH_LENGTH, basePath); + } + else if (filter != NULL) { if (IsPathFile(path)) { @@ -3742,12 +3746,16 @@ static void ScanDirectoryFilesRecursively(const char *basePath, FilePathList *fi { // Construct new path from our base path #if defined(_WIN32) - sprintf(path, "%s\\%s", basePath, dp->d_name); + int realPathLength = snprintf(path, sizeof(path) - 1, "%s\\%s", basePath, dp->d_name); #else - sprintf(path, "%s/%s", basePath, dp->d_name); + int realPathLength = snprintf(path, sizeof(path) - 1, "%s/%s", basePath, dp->d_name); #endif - if (IsPathFile(path)) + if (realPathLength < 0 || realPathLength >= sizeof(path)) + { + TRACELOG(LOG_WARNING, "FILEIO: Path longer than %d characters (%s...)", MAX_FILEPATH_LENGTH, basePath); + } + else if (IsPathFile(path)) { if (filter != NULL) {