瀏覽代碼

[rcore] Use snprintf to prevent buffer overflow in path construction

pull/4833/head
MykBamberg 2 天之前
父節點
當前提交
daa2921476
共有 1 個文件被更改,包括 14 次插入6 次删除
  1. +14
    -6
      src/rcore.c

+ 14
- 6
src/rcore.c 查看文件

@ -3688,12 +3688,16 @@ static void ScanDirectoryFiles(const char *basePath, FilePathList *files, const
(strcmp(dp->d_name, "..") != 0))
{
#if defined(_WIN32)
sprintf(path, "%s\\%s", basePath, dp->d_name);
kt">int realPathLengthspan> = snprintf(path, sizeof(path) - 1, "%s\\%s", basePath, dp->d_name);
#else
sprintf(path, "%s/%s", basePath, dp->d_name);
kt">int realPathLengthspan> = snprintf(path, sizeof(path) - 1, "%s/%s", basePath, dp->d_name);
#endif
if (filter != NULL)
if (realPathLength < 0 || realPathLength >= sizeof(path))
{
TRACELOG(LOG_WARNING, "FILEIO: Path longer than %d characters (%s...)", MAX_FILEPATH_LENGTH, basePath);
}
else if (filter != NULL)
{
if (IsPathFile(path))
{
@ -3742,12 +3746,16 @@ static void ScanDirectoryFilesRecursively(const char *basePath, FilePathList *fi
{
// Construct new path from our base path
#if defined(_WIN32)
sprintf(path, "%s\\%s", basePath, dp->d_name);
kt">int realPathLengthspan> = snprintf(path, sizeof(path) - 1, "%s\\%s", basePath, dp->d_name);
#else
sprintf(path, "%s/%s", basePath, dp->d_name);
kt">int realPathLengthspan> = snprintf(path, sizeof(path) - 1, "%s/%s", basePath, dp->d_name);
#endif
if (IsPathFile(path))
if (realPathLength < 0 || realPathLength >= sizeof(path))
{
TRACELOG(LOG_WARNING, "FILEIO: Path longer than %d characters (%s...)", MAX_FILEPATH_LENGTH, basePath);
}
else if (IsPathFile(path))
{
if (filter != NULL)
{

Loading…
取消
儲存